search

rust-lang / crater

Run experiments across parts of the Rust ecosystem!
https://crater.rust-lang.org
629 stars 88 forks source link

number of "completed jobs" change after crater completed #735

Closed matthiaskrgr closed 2 weeks ago

matthiaskrgr commented 2 weeks ago

https://github.com/rust-lang/rust/pull/129660#issuecomment-2322863484

https://crater.rust-lang.org/ex/crater-rollup-uwu

the crater run was done and report was generated. I watched the summary page and hit f5 a couple of times and you can see "completed jobs" number go down???

Note that another crater job was also running directly after that one. https://crater.rust-lang.org/ex/pr-126452-1

matthiaskrgr commented 2 weeks ago

https://github.com/user-attachments/assets/744ca453-b3be-44f1-81bc-63b206ae0b4f

matthiaskrgr commented 2 weeks ago

it seems that past crater runs have their "completed jobs" reduced to "0/0" ?? https://crater.rust-lang.org/ex/pr-129466

I guess something is a bit broken as it "adds" more completed jobs to the current run, crater accidentally subtracts them from the previous run? :sweat_smile:

Mark-Simulacrum commented 2 weeks ago

Previous runs are (mostly) pruned from the database, so we don't keep track of the count of jobs etc. anymore.

matthiaskrgr commented 2 weeks ago

would it make sense to store this as a 2 static numbers somewhere just for display?

Mark-Simulacrum commented 2 weeks ago

It would be a hassle and doesn't seem worth it to me. Why do you care about previous runs? The report is stored in S3 and has links to e.g. tarballs containing all logs, so the UI doesn't seem particularly useful.

matthiaskrgr commented 2 weeks ago

Just found that it looked very weird... But understandable, closing.