search

rust-lang / crates-build-env

Build environment for third-party Rust crates
MIT License
69 stars 89 forks source link

FFI upgrade golang version to >= 1.19 #119

Closed neonphog closed 1 year ago

neonphog commented 1 year ago

https://docs.rs/crate/tx5-go-pion-sys/0.0.1-alpha.1/builds/723243

[INFO] [stderr]   thread 'main' panicked at 'go executable version must be >= 1.19, got: 1.13', build.rs:42:5
neonphog commented 1 year ago

Why is ubuntu's golang so old? Would it be possible to switch to jammy? That at least has 1.17 (https://packages.ubuntu.com/jammy/golang-1.17] I might be able to pair back the deps that far.

syphar commented 1 year ago

We're tracking ubuntu LTS for these images.

A upgrade to jammy is possible, but is some work (see also #84 ).

I'm happy to review a PR :)

neonphog commented 1 year ago

I assume you meant see also #84. Awesome I'll spend a little time on that today.

syphar commented 1 year ago

oh yeah, you're right :)

syphar commented 1 year ago

I assume the golang version is now up-to-date with the new image (#120) and will close this issue.

Thank you!

neonphog commented 1 year ago

Yep, build env is now up to go 1.18, and I was able to reduce the requirement down to 1.18. Thanks for your help!

syphar commented 1 year ago

Thank you for yours!