search

rust-lang / crates-build-env

Build environment for third-party Rust crates
MIT License
69 stars 89 forks source link

linux: add linux-headers-generic #30

Closed alexforster closed 4 years ago

alexforster commented 4 years ago

Needed to build my libbpf-sys crate.

jyn514 commented 4 years ago

@alexforster The changes are merged but the crate environment won't be updated until the docker image gets published and I restart the server. I can schedule a rebuild after that.

alexforster commented 4 years ago

Cool, no rush. Thanks!

jyn514 commented 4 years ago

@alexforster I rebuilt it, but the build script trying to modify the source directory which isn't allowed in the sandbox. You'll have to fix that on your end. As an alternative, you could try writing to OUT_DIR (set by Cargo).

alexforster commented 4 years ago

Ah okay this is an easy fix. Thanks again, I really appreciate the responsiveness.

jyn514 commented 4 years ago

No problem! I like helping with build failures, they're usually pretty simple to fix :)

By the way, the 'dependencies metadata' feature isn't broken, it was just never implemented, that's why it wasn't documented. We want to share the build environment with Crater so it looks like it probably won't ever be added, we should remove it internally at some point.