search

rust-lang / crates-build-env

Build environment for third-party Rust crates
MIT License
69 stars 89 forks source link

Port to 20.04 #43

Closed rakshith-ravi closed 4 years ago

rakshith-ravi commented 4 years ago

I couldn't find a replacement for these packages:

libcloog-isl4
libelektra-dev
libiculx60
libmariadbclient18
libntdb1
libpolkit-backend-1-0
libsane-extras
libsane-extras-common
libv8-3.14.5
libv8-dev
vdpau-va-driver

Any idea on what to do about these packages? The docker image builds successfully without them though.

@jyn514 @nellshamrell

Mark-Simulacrum commented 4 years ago

Locally, running 20.04, I see libmariadbclient-dev -- can you check that again? I can confirm that cursory searches do not yield results for the others.

rakshith-ravi commented 4 years ago

Oh yeah, I forgot to mention that. The libmariadbclient-dev package exists, but seems to be clashing with libmysqlclient-dev. It wouldn't let me install them together.

rakshith-ravi commented 4 years ago

Okay hold on, I think I may have confused the packages. libmariadbclient-dev works, but libmariadbclient18 doesn't seem to have an installation candidate. In fact, my PR has the libmariadbclient-dev and libmariadbclient-dev-compat package in it.

Sorry about the confusion. I'll update the initial post

jyn514 commented 4 years ago

libmariadbclient18

This is left over from the initial commit, so I think as long as we have the development headers it's fine not to keep it.

libcloog-isl4 libntdb1

As mentioned in https://github.com/rust-lang/crates-build-env/pull/42#issuecomment-619637839 I think it's fine to get rid of these.

libelektra-dev

This has not be packaged upstream, see https://github.com/ElektraInitiative/libelektra/issues/3412. I think it's fine not to keep it in the meantime, we can add it back later if/when it gets packaged.

libiculx60 libpolkit-backend-1-0 libv8-3.14.5 libv8dev vdpau-va-driver

These are also from the initial commit, I'm ok with not keeping them. There doesn't seem to be a replacement package in 20.04.

libsane-extras libsane-extras-common

These appear to have been renamed to libsane and libsane-common, try adding those.

rakshith-ravi commented 4 years ago

Done. libsane and libsane-common is added. Not sure why the travis build was failing though. Something about a task not found.

jyn514 commented 4 years ago

The error is

Lint error: packages.txt is not sorted

You can fix it with sort packages.txt > tmp && mv tmp packages.txt.

rakshith-ravi commented 4 years ago

Updated

jyn514 commented 4 years ago

Thanks so much for working on this!