search

rust-lang / crates-build-env

Build environment for third-party Rust crates
MIT License
71 stars 92 forks source link

Apply `sort` to packages.txt, and apply sort check step in CI #67

Closed ShadowJonathan closed 3 years ago

ShadowJonathan commented 3 years ago

Maybe a bit too "nit-picky", but when i added packages for #66, and applied sort packages.txt > out.txt, and then copy-pasted contents of that file into the old one, my VCS diff showed a lot more packages being shuffled around than i was expected.

Maybe add this pre-requisite step into the project's CI? To check if the file has been sorted correctly, to also avoid duplicates and the like.

The current file is pseudo-hand-sorted, which may not be useful when the actual goal is to have a sorted file.

ShadowJonathan commented 3 years ago

(whoops, sorry for the package request label, couldn't remove that one)

ShadowJonathan commented 3 years ago

...i appearantly cannot look at the .travis.yml file, hm