search

rust-lang / crates-build-env

Build environment for third-party Rust crates
MIT License
69 stars 89 forks source link

Add packages necessary for compiled-nn-bindings to compile #95

Closed h3ndrk closed 2 years ago

h3ndrk commented 2 years ago

This PR adds libhdf5-dev to the build environment to make the crate compiled-nn-bindings compile. Latest build failure: https://docs.rs/crate/compiled-nn-bindings/0.1.0/builds/479931

h3ndrk commented 2 years ago

@syphar Thanks for merging! Is there a way for retriggering the build without pushing a new version? (Affects compiled-nn and compiled-nn-bindings)

syphar commented 2 years ago

@h3ndrk I just re-queued a build for both releases.

h3ndrk commented 2 years ago

Thank you! :+1:

h3ndrk commented 2 years ago

@syphar The re-queued build used the Docker image sha256:a429bb59b7a3b4e7270a4b4c243bb115fc561d8f62ec34ef63a0a36cabf65dfd (see https://docs.rs/crate/compiled-nn/0.1.0/builds/489363) which is about one month old and does not have libhdf5-dev installed... The image from yesterday would be sha256:0cd99ca24d8e8c98e67c542213511d985b8778b5bdcbb160e038429496686047.

The re-queued build did therefore not succeed. Other crates seem to also be built using the older image.

Would be very cool if you could update the image and re-queue compiled-nn and compiled-nn-bindings again. Thank you very much!

syphar commented 2 years ago

@h3ndrk I forgot about the needed server-restart, sorry about that.

While deploying some PRs I did it anyway, and requeued the two packages.

From other packages build-logs after the deploy it looks like the new image is used now, but I'm happy to check again if it still doesn't work.

Sorry for the delay :)

h3ndrk commented 2 years ago

Thanks for you time! The builds succeeded now. :smiley::+1: