rust-lang / crates.io

The Rust package registry
https://crates.io
Apache License 2.0
2.93k stars 597 forks source link

Should the width for the content be increased? #1559

Open MaikKlein opened 5 years ago

MaikKlein commented 5 years ago

First of all I am not a webdev.

I always felt that crates.io looks a bit cramped on my desktop machine.

For example this is how it currently looks

After I changed the width

Now it has the same size as Github. I personally think this would be an improvement, what do you think?

carols10cents commented 5 years ago

Having the README be the same width as GitHub, at least for crate show pages, would probably be nice. Not sure if that should extend to search pages or settings pages or the other pages we have, and if not, if it would be weird that the widths change...

moonheart08 commented 4 years ago

Maybe make it.. not be fixed width? Please? Screen sizes above 16:9 really suffer, and a lot of screen space is wasted. Pictured is a 21:9 display viewing crates.io. image

miDeb commented 3 years ago

There was already an issue for that (https://github.com/rust-lang/crates.io/issues/970), but if you go to the linked page https://crates.io/crates/colorparse today, it looks more like the "before" in the gif of the closing pr https://github.com/rust-lang/crates.io/pull/1064. Maybe that's even a regression?

ibaryshnikov commented 3 years ago

Hi all! What's the state of this issue? Any desire to make a change for wider screens? It looks like here's the place responsible for the docs width https://github.com/rust-lang/crates.io/blob/575b2fb97a492624e75e550fdebae209d1904906/app/styles/crate/version.module.css#L13-L19

Turbo87 commented 3 years ago

we're slowly working towards a state of the code where we should be able to increase the width without too many issues :)

ibaryshnikov commented 3 years ago

Does it break something else when increased?

Turbo87 commented 2 years ago

@ibaryshnikov yes, see https://github.com/rust-lang/crates.io/issues/3687#issuecomment-857418731 for example 😅