A few readability and performance improvements

rust-lang / datafrog

A lightweight Datalog engine in Rust

Apache License 2.0

796 stars 43 forks source link

A few readability and performance improvements #13

Closed ljedrz closed 6 years ago

ljedrz commented 6 years ago

prefer is_empty() to len() > 0 and len() != 0
collect into Vectors or extend() instead of pushing in a loop where possible
a few minor readability tweaks

ljedrz commented 6 years ago

~~I only now noticed that #12 also introduces a collect for map; I'll update my commit to remove it shortly.~~ Done.

frankmcsherry commented 6 years ago

These look good, thank you. The side-effecting filter weirds me out a bit, but that could just be something I need to get over. :)

I'm hesitant to unilaterally merge myself (I'm not the one using the repo), but if we don't hear from @lqd soon we can. Looks good to me, though!

lqd commented 6 years ago

@frankmcsherry oh don't worry about me ! You built the thing and your approval is the one which matters :) Maybe before/after numbers, for example the Polonius use case (on the clap-rs benchmark) could be helpful in cases like this one, at least until we have more datafrog benchmarks ?