rust-lang / datafrog

A lightweight Datalog engine in Rust
Apache License 2.0
796 stars 43 forks source link

Split-up lib.rs #32

Closed regexident closed 3 years ago

regexident commented 3 years ago

This PR splits up the lib.rs file, introducing separate files for:

Splitting up the single 555loc file required me to make a select few previously private bindings pub(crate), instead. However I think overall this greatly improves the accessibility of the project and is worth it.


This is part #1 of a stacked pull-request:

└── Split-up\ lib.rs 👈🏻
    └── Cleanup\ generics (#33)
        └── Support arbitrary tuples (#34)
ecstatic-morse commented 3 years ago

Hi @regexident!

I'm in full agreement with this PR, however I think the only active person with r+ rights in this repo is @nikomatsakis, and they are quite busy. I'll try to convince them to give either @lqd or me (preferably both) permission to approve PRs so we can get things moving.

ecstatic-morse commented 3 years ago

I have some stuff in the pipeline that will conflict with this, so I went ahead and added the nit on top before merging (I would have rebased but it's non-trivial to preserve authorship info this way). Thanks again @regexident.

regexident commented 3 years ago

Thanks @ecstatic-morse!