search

rust-lang / discord-mods-bot

discord moderation bot
MIT License
72 stars 30 forks source link

fix CharacterSet::any to match non-ascii chars #65

Closed tinaun closed 3 years ago

tinaun commented 3 years ago

helps with, but does not "close" #64 - now commands that take "any value" as an argument will properly handle non ascii chars, but you still can't use a CharacterSet to match a specific set of non-ascii chars

technetos commented 3 years ago

I completely understand needing to allow non-ascii chars in an any charset, but is there a situation where we need to specifically accept a non-ascii char? This design was intentional, its not often (ever) we have commands to the bot that are non-ascii.

tinaun commented 3 years ago

for consistency, i guess?

this pr is the most important part and all i really care about, you can close the linked issue if you feel like its not an issue worth resolving.