search

rust-lang / docker-rust

The official Docker images for Rust
430 stars 89 forks source link

Add tools version of containers #122

Open Christiaan676 opened 1 year ago

Christiaan676 commented 1 year ago

Adds a tools version of the containers, that adds the following rust components: rustfmt, clippy and llvm-tools-preview. More rust components could be added. But this seams to me the most applicable set for CI.

Al lot of firsts in this pull-request so let me know if I need to change something.

Solves issue: #97

Trolldemorted commented 9 months ago

@sfackler @Muscraft @sksat could you accept or refuse this PR, or is this repository abandonware except for the version bumps?

Muscraft commented 9 months ago

I'm sorry that I won't be able to help as I'm not a maintainer of this repository, so I have no ability to accept or reject this PR.

That being said saying "or is this repository abandonware except for the version bumps" is both incorrect (there have been PRs that add things) and it can be off-putting to maintainers, hurting your cause. We have no idea what is going on in their day to day lives, or how much time they have to commit to maintaining this repository. I understand it can be frustrating for a PR to be open for a long time with no decision on what to do with it. A better way to handle this situation is to ask politely for a review and if you feel up to it, give more context for why the PR is wanted in the first place.

sksat commented 9 months ago

I'm also not a maintainer of this repository.

Personally, this feature is my wish too, but I strongly agree with Muscraft that a polite request should be made. In general, accumulating messy mentions that lack background makes maintainers less and less willing to respond to notifications......

police999a commented 4 months ago

https://github.com/docker/scout-demo-service.git