search

rust-lang / docker-rust

The official Docker images for Rust
428 stars 89 forks source link

Add ppc64le support #156

Closed Jenkins-J closed 5 months ago

Jenkins-J commented 10 months ago

Add ppc64le support to Rust bullseye and bookworm images. The Debian buster container image does not currently support the ppc64le architecture. This builds on the work in pull request #101 and addresses issue #54.

mkumatag commented 10 months ago

@sfackler can you please review this PR?

clnperez commented 9 months ago

@Jenkins-J looks like this needs a rebase

Jenkins-J commented 9 months ago

@sfackler I've rebased the changes for this pull request. Is there anything else I need to do to have this reviewed and merged?

Jenkins-J commented 8 months ago

@sfackler there are projects such as https://github.com/IBM/text-generation-inference that aim to support the ppc64le architecture and would benefit from ppc64le support in the official Rust Docker image. Are there any other blockers to adding ppc64le support?

Jenkins-J commented 6 months ago

@sfackler @Muscraft I have rebased the changes on the master branch again. Is there anything else holding this PR back from being merged?

Muscraft commented 5 months ago

The reason this has been hard to decide on is there is currently no policy on what architectures we support similar to rustc's Platform Support.

After talking with @sfackler, we should support architecture that meets the following criteria:

One caveat is that I don't have any hardware to test images for architectures other than amd64 and arm64v8 so other architectures are best effort.

clnperez commented 5 months ago

One caveat is that I don't have any hardware to test images for architectures other than amd64 and arm64v8 so other architectures are best effort.

@Muscraft - We have an agreement with OSU that you can, as a maintainer of an open source project, get an OpenStack-managed Power VM there pretty easily: https://osuosl.org/services/powerdev/request_hosting. They'll spin you up a VM, add your SSH key to it, and it's yours. If you're interested let me know. But we're fine with the best effort approach and are happy to be pinged to fix things as well.

Thanks for the review!

Muscraft commented 5 months ago

docker-library/official-images#16055