search

rust-lang / docker-rust

The official Docker images for Rust
428 stars 89 forks source link

feat: Add publishing of nightly Rust versions #175

Closed Muscraft closed 4 months ago

Muscraft commented 5 months ago

The images for nightly versions of rust, produced by rust-lang/docker-rust-nightly have diverged significantly over time, and recently stopped being published nightly. Seeing both of these things, it would make sense to move all rust related docker images to be managed within one repo. This has the benefit of ensuring we keep the images in sync while having one spot to look at in case of problems.

Merging this PR will not immediately make the nightly images get published from here. We do not have a secret for Docker hub, as well as the images published to ghcr.io/rust-lang/rust are still tied to docker-rust-nightly and will need to be moved (if possible).

sfackler commented 5 months ago

The Docker Hub publishing is performed by the rustopsbot account: https://hub.docker.com/u/rustopsbot. I think T-infra owns it? I vaguely remember them setting up the ghcr token as well.

sfackler commented 5 months ago

LGTM otherwise though.

Muscraft commented 5 months ago

LGTM otherwise though.

What do you mean by this? Are you saying this should be merged now, or should I merge it once we get the publishing setup with rustopsbot and ghcr?

sfackler commented 5 months ago

I'd probably wait until we get the tokens so the build won't be failing every night.

jdno commented 4 months ago

I've created a new token for the rustopsbot user on Docker Hub and added it as the DOCKER_HUB_TOKEN to the repository secrets. :+1:

sfackler commented 4 months ago

Let's land it!

Muscraft commented 4 months ago

I commented out the parts for publishing to GitHub packages, so that we can at least land the publishing to Docker