Should we add alpine-sdk in this image?

rust-lang / docker-rust

The official Docker images for Rust

436 stars 88 forks source link

Should we add alpine-sdk in this image? #73

Closed ghost closed 3 years ago

ghost commented 3 years ago

Proposal:

Add alpine sdk in images

Reason:

This image commonly faces error with linking with "cc" failed: exit code: 1.
ref: https://github.com/rust-lang/rust/issues/25289
ref: https://github.com/gliderlabs/docker-alpine/issues/294
Not a few dependencies requires this toolchain such as proc_macro, so I think this proposal helps many people.

As approved, I will send PR.

jbg commented 3 years ago

Would be better to include build-base; alpine-sdk contains a bunch of other things for making Alpine releases that don't really need to be in an image like this.

ghost commented 3 years ago

I see.