search

rust-lang / docs.rs

crates.io documentation generator
https://docs.rs
MIT License
956 stars 193 forks source link

Namespace docs.rs theme setting #2464

Closed Nemo157 closed 3 months ago

Nemo157 commented 3 months ago

Fixes #2462 (at least issues from our side, the default theme now works as rustdoc implements it which may still not be what is wanted).

GuillaumeGomez commented 3 months ago

Could add a GUI test for this please?

Nemo157 commented 3 months ago

@GuillaumeGomez there's no way to do multi-tab tests in goml-script is there?

GuillaumeGomez commented 3 months ago

Not currently no. Each test is run into its own tab.

Nemo157 commented 3 months ago

Which is itself an issue since theming is cross-tab synchronized

GuillaumeGomez commented 3 months ago

They don't share states apparently. Might be linked to how puppeteer handles it internally, otherwise rustdoc tests would have quite a lot of trouble since a lot of tests change the theme to check colors.

GuillaumeGomez commented 3 months ago

Just some small improvements to be done to ensure the GUI test won't become flaky but otherwise looks good, thanks!

syphar commented 3 months ago

@GuillaumeGomez @Nemo157 I didn't test anything here, but this PR is ready to be merged from your sides?

GuillaumeGomez commented 3 months ago

Didn't test it but I'm confident thanks to the GUI test. ;)

Nemo157 commented 3 months ago

Yeah, I did some manual testing before the GUI test so this should be good to go.

GuillaumeGomez commented 3 months ago

Then let's merge!