search

rust-lang / docs.rs

crates.io documentation generator
https://docs.rs
MIT License
956 stars 193 forks source link

Update to eslint v9 #2489

Open Nemo157 opened 2 months ago

Nemo157 commented 2 months ago

Switch to using deno as that allows referring to the config packages without having to setup a package.json and other stuff required when running eslint through node now.

Nemo157 commented 2 months ago

I have an alternative using node with a package.json instead if anyone has opinions on which to use: https://github.com/Nemo157/docs.rs/commit/2f41680fd1e02274252ab0450d687e43cbea6dc8

GuillaumeGomez commented 2 months ago

I have an alternative using node with a package.json instead if anyone has opinions on which to use: Nemo157@2f41680

No preference on my side, so whichever sounds best to you.

Nemo157 commented 2 months ago

My preference is this approach with deno, it avoids having to manage the whole package-lock.json when we don't really care about the transitive deps.

syphar commented 2 months ago

@Nemo157 @GuillaumeGomez I'm not sure I fully follow, is anything missing here? Or is this ready to be merged?

Generally you two can merge too :)

GuillaumeGomez commented 2 months ago

I prefer to let PR owners with merge rights to merge their own PRs once approved so it's waiting on @Nemo157 here. ;)