search

rust-lang / docs.rs

crates.io documentation generator
https://docs.rs
MIT License
977 stars 195 forks source link

fix serving custom CSS coming from --extend-css in rustdoc #2525

Closed syphar closed 3 months ago

syphar commented 3 months ago

Resolves #2524

The CSS content from --extend-css ends up in a theme.css in the rustdoc output.

We have to serve these similar to invocation specific JS files.

I added a test testing for both custom JS & CSS files, also validated locally that the bug in #2524 is fixed

GuillaumeGomez commented 3 months ago

I thought this case was handled already. Good catch!

hedgecrw commented 3 months ago

Thanks for the quick fix everyone! One quick question/request...is there a way to manually trigger a re-build of the current docs for a release, or will I need to just up the version number and republish to take advantage of this fix?

syphar commented 3 months ago

It's actually option 3 :

We still only manually deploy docs.rs, which is why we have this "waiting for deploy" label.

I'll probably do a deploy tomorrow or the day after, then everything should directly be fine.

hedgecrw commented 3 months ago

Perfect, thanks again

syphar commented 3 months ago

@hedgecrw the code is deployed, everything should work now, can you confirm?

hedgecrw commented 3 months ago

I can confirm that everything now looks correct.