search

rust-lang / docs.rs

crates.io documentation generator
https://docs.rs
MIT License
956 stars 193 forks source link

show in-progress builds in build queue & build-list pages #2533

Open syphar opened 6 days ago

syphar commented 6 days ago

Resolves #1011. ( last piece IMO)

this will start showing in-progress builds mainly in:

on top of already redirecting to the build-list when someone tried to access a new in-progress crate.

I'm not 100% certain if we will open up the handlers to some new errors when called on a in-progress crate, but IMO we just have to see and act when there are errors.

One caveat:

Perhaps I'm missing something, but I believe we will have an issue around server restarts and in-progress builds. When we stop / restart our server process we will just stop building without updating our build-status in the database. So we might have "orphaned" in-progress builds.

I'm not sure yet how to solve this the best way, I think the correct solution is a proper graceful shutdown involving rustwide doesn't feel simple. The shutdown would also have to be per build-server, so autoscaling buildservers in the future doesn't reset the build status for builds on other build-servers.

A workaround if we see this happening would probably be to manually reset the build-status for in-progress builds in our deploy-script.

syphar commented 6 days ago

some screenshots:

grafik grafik
GuillaumeGomez commented 6 days ago

The position of the cog in the second screenshot seems weird, no?

syphar commented 6 days ago

The position of the cog in the second screenshot seems weird, no?

True...

looking at the HTML I have no idea (yet) where this can come from. super odd

GuillaumeGomez commented 6 days ago

I can take a look if you want. Can you host the webpage with its style somewhere?

syphar commented 5 days ago

I'll not merge this PR before I solved the new sentry errors / panics I'm seeing, that are regressions from #2467