Open pflanze opened 6 days ago
I think I've handled all of your suggestions, but I forgot about Clippy. I'll need to get back to that another evening.
Oh build failures:
error: set
DATABASE_URL
to use query macros online, or runcargo sqlx prepare
to update the query cache
Not sure right now what to do about this (need to stop for tonight).
Oh build failures:
error: set
DATABASE_URL
to use query macros online, or runcargo sqlx prepare
to update the query cacheNot sure right now what to do about this (need to stop for tonight).
I've put the necessary command into our Justfile
, so calling just sqlx-prepare
is fine
Thank you for all the work! This will be awesome for crate authors
I've so far avoided to force-push and instead pushed 3 commits (those with subject lines starting with "sq", standing for squash) with changes that I will squash into the earlier commits where they belong; the idea is that this makes it easier for you to see what I changed; this assumes that diffing is easier as a last step after I do the squashing together with the right commits and force-pushing at the end. Let me know once you're happy and I'll do that. And if that was useful or rather a complication.
I've realized that you can still see the commit from before me squashing the commits anyway and have now force-pushed db8b3636...b7deb0d7 (i.e. if you'd like to see the incremental changes I did easily, look at db8b3636, for the state I wish to be merged b7deb0d7).
I've pushed 3 commits with (a) the 'optimized' SQL query, FWIW, (b)+(c) add and use the constant_time_eq crate for token comparisons. Without it, it would likely be possible for attackers to find the token via response times.
relates to #2442.
adds config variable
DOCSRS_TRIGGER_REBUILD_TOKEN
/Config.trigger_rebuild_token
adds
build_trigger_rebuild_handler
and route "/crate/:name/:version/rebuild"Note: does not yet contain any kind of rate limiting!