search

rust-lang / docs.rs

crates.io documentation generator
https://docs.rs
MIT License
989 stars 198 forks source link

do not replace old docs if rebuild failed #2675

Open dhardy opened 2 hours ago

dhardy commented 2 hours ago

Crate name

rand

Build failure link

https://docs.rs/crate/rand/latest/builds

Additional details

It seems that rand 0.8.5 docs got rebuilt yesterday? Strange; I haven't seen docs.rs just rebuild old docs before. And unfortunately, the rebuild fails due to a nightly feature which got changed since then.

Can you reinstate the old docs build please?

CC https://github.com/rust-random/rand/issues/1528

GuillaumeGomez commented 2 hours ago

Changing the issue to "do not replace old docs if rebuild failed".

syphar commented 2 hours ago

this is super odd, I actually tested this case and saw that old docs were kept before I started rebuilding...

syphar commented 2 hours ago

( reinstanting the old docs is a little tricky, a rebuild would be easier if rand would stop using the fature)

dhardy commented 1 hour ago

I can do. I dread to think how many person-hours will be consumed just checking the changelog...

syphar commented 1 hour ago

( there might be a quicker way on our side, I probably can look into it tomorrow)

dhardy commented 1 hour ago

Would be good. I opened a PR, but the CI is not happy. I guess I could just ignore that. https://github.com/rust-random/rand/pull/1529