search

rust-lang / flate2-rs

DEFLATE, gzip, and zlib bindings for Rust
https://docs.rs/flate2
Apache License 2.0
891 stars 158 forks source link

Remove `tokio` support #292

Closed Expyron closed 2 years ago

Expyron commented 2 years ago

Following discussion in #214

The current support is for tokio 0.1, which is very outdated.

Crate async-compression provides async integration if needed, so rather than upgrading to the latest version of tokio, this is a blanket removal of the feature.

This removal is a breaking change only if the feature is enabled, so I'm not sure how it should be tied to a version change. I cannot find any dependent crate on crates.io which uses the tokio feature

alexcrichton commented 2 years ago

Seems reasonable to me, thanks for the PR!

Madoshakalaka commented 2 years ago

Can somebody please update the documentation on docs.rs and the REAME? I wasted a lot of time figuring out why it wouldn't work with tokio :(