search

rust-lang / flate2-rs

DEFLATE, gzip, and zlib bindings for Rust
https://docs.rs/flate2
Apache License 2.0
869 stars 159 forks source link

Add CIFuzz Github action #326

Closed DavidKorczynski closed 1 year ago

DavidKorczynski commented 1 year ago

Add CIFuzz workflow action to have fuzzers build and run on each PR.

This is a service offered by OSS-Fuzz where flate2-rs already runs. CIFuzz can help detect regressions and catch fuzzing build issues early, and has a variety of features (see the URL above). In the current PR the fuzzers gets build on a pull request and will run for 300 seconds.

Mark-Simulacrum commented 1 year ago

This seems fine, but we may want to update the original cc list for failures - https://github.com/google/oss-fuzz/pull/5599/files#diff-a4e84032c8eeac617821c8f137b2d9c905e295837217ad3cc81960d9d242699cR10

I'm not sure this affects the PR configuration, but presumably affects something. https://github.com/rust-lang/team/blob/master/teams/libs.toml#L43 seems like a reasonable email to use, though we can also define one for crate-maintainers specifically.

JohnTitor commented 1 year ago

I'm not sure this affects the PR configuration, but presumably affects something. rust-lang/team@master/teams/libs.toml#L43 seems like a reasonable email to use, though we can also define one for crate-maintainers specifically.

I'm a bit concerned that sending fuzzing failures emails to t-libs could be noisy, so preparing an alias for crate-maintainers sounds better to me.