search

rust-lang / flate2-rs

DEFLATE, gzip, and zlib bindings for Rust
https://docs.rs/flate2
Apache License 2.0
929 stars 163 forks source link

update maintenance guide with recent news #419

Closed Byron closed 3 months ago

Byron commented 3 months ago

This might be interesting to our new maintainer, @jongiddy - welcome 🎉.

jongiddy commented 3 months ago

In the cargo publish section there is an instruction to get it merged which implies getting approval to merge. There should be something similar in the cargo smart-release section. In both sections, maybe it should read get the PR approved and merged.

Byron commented 3 months ago

Thanks for the review, @jongiddy , I am very happy to not be left alone here anymore :).

My first suggestion is to remove the remnants of the cargo smart-release experiment and go back to doing it like previously described. If you agree, I invite you to make the changes you'd find useful directly and push them to this branch - that's easier and faster as well.

Byron commented 3 months ago

Now that you are maintainer @jongiddy , you will probably be able to push into this branch to complete it. I guess it's my way of saying "hi, and welcome" :).

jongiddy commented 3 months ago

I removed the smart-release section and revised the text of the other sections.

jongiddy commented 3 months ago

@Byron The repo has auto-merge set, so the PR is automatically merged by you when any maintainer approves. That setting may not make as much sense with multiple maintainers.

Byron commented 3 months ago

I think that might have been set for this PR only, I wouldn't expect that to happen next time unless it's explicitly enabled on a per PR basis.

If it really is a repository setting, probably none of us has the permission to change it.