search

rust-lang / futures-rs

Zero-cost asynchronous programming in Rust
https://rust-lang.github.io/futures-rs/
Apache License 2.0
5.34k stars 616 forks source link

Consider pollster as the futures_executor::block_on implementation #2739

Closed e00E closed 1 year ago

e00E commented 1 year ago

This is related to https://github.com/zesterer/pollster/issues/21 where I ask what differences between pollster and futures_executor. Both crates aim to accomplish the same thing so why duplicate the effort. I didn't find a mention of pollster in this repository so here I am bringing it up.

notgull commented 1 year ago

Personally, I would say that the minimal duplicated effort is worth it compared to the trade off of adding a new dependency.

taiki-e commented 1 year ago

futures_executor has been around for many years before pollster and also provides things like thread pools that pollster does not provide.

You are free to extract code from futures under the appropriate license and copyright notice (there are many such crates. although I don't know how the pollster was created), but they are all unofficial, not reviewed by futures maintainers, and there is no motivation on futures side to mention them.

taiki-e commented 1 year ago

there is no motivation on futures side to mention them.

Also, even if there is a motivation, it is not always easy to mention a specific third-party crate from a crate that belongs to rust-lang or its project. If some over-passionate stakeholders feel that their project is being treated unfairly, they will try to "correct" it in various ways. Some of them can feel like spam or threats.