rust-lang / futures-rs

Zero-cost asynchronous programming in Rust
https://rust-lang.github.io/futures-rs/
Apache License 2.0
5.38k stars 622 forks source link

Add esp32s2 to no CAS list #2805

Closed MabezDev closed 10 months ago

MabezDev commented 10 months ago

Without this entry, esp32s2 users with futures-* dependencies in their tree, indirectly or not must somehow enable the portable atomic feature. This change makes it seamless like it is on RISCV etc.

taiki-e commented 10 months ago

Thanks for the PR. I would prefer not to accept a way to manually manage such a list of platforms. I've said this many times in other repos like https://github.com/crossbeam-rs/crossbeam/pull/751#pullrequestreview-796739843, https://github.com/crossbeam-rs/crossbeam/pull/937#issuecomment-1338885510.

Instead, I would accept a patch to use target_has_atomic = "ptr", like done in crossbeam https://github.com/crossbeam-rs/crossbeam/issues/1033.