Implement Deref{Mut} for AllowStdIo.

rust-lang / futures-rs

Zero-cost asynchronous programming in Rust

https://rust-lang.github.io/futures-rs/

Apache License 2.0

5.31k stars 609 forks source link

Implement Deref{Mut} for AllowStdIo. #2808

Closed Frostie314159 closed 4 months ago

Frostie314159 commented 7 months ago

This PR adds Deref{Mut} which internally just call get_{ref|mut}, which will stay, as to not break compatibility.

Frostie314159 commented 7 months ago

The clippy lint as well as the rustdoc crash appear to be unrelated to this PR, does anyone know why they are happening. I tested it against the latest nightly version of clippy and rustdoc and both succeed with out warnings.

Frostie314159 commented 7 months ago

The bug causing the CI failure was patched in the latest release of rustdoc.

taiki-e commented 4 months ago

I think this could cause breakage if a different method with the same name as a method in std::io traits is added to futures::io traits.

taiki-e commented 4 months ago

Closing this due to the above concern.

Thanks anyway for the PR!