search

rust-lang / futures-rs

Zero-cost asynchronous programming in Rust
https://rust-lang.github.io/futures-rs/
Apache License 2.0
5.38k stars 622 forks source link

Ignore newly added clippy lint #2823

Closed taiki-e closed 8 months ago

taiki-e commented 8 months ago

Hmm... it seems that someone has changed the configuration of this repository.

gh

It is problematic to set up such ("one approval required") branch protection in a project where there is effectively only one maintainer, but they do not have the permissions to bypass the branch protection.

taiki-e commented 8 months ago

Ok, I believe that is due to https://github.com/rust-lang/team/pull/1187.

cc @Kobzol

I apologize for not being able to comment on that issue sooner, but I can't find an explanation about the possibility of such problems. Could you tell me what needs to be done to fix this? Is it just a removal of the table regarding branch protection? Or can it be adjusted by adding a specific field?

taiki-e commented 8 months ago

Could you tell me what needs to be done to fix this? Is it just a removal of the table regarding branch protection? Or can it be adjusted by adding a specific field?

(It would be ideal if it would give me the (admin?) permission to bypass the protections when necessary...)

Kobzol commented 8 months ago

Sorry for that, I missed that approvals weren't required before! https://github.com/rust-lang/team/pull/1225 should fix it.

Kobzol commented 8 months ago

I'll investigate why it didn't work.

taiki-e commented 8 months ago

The branch protection issue seems to be fixed now (by https://github.com/rust-lang/sync-team/pull/62?). Thanks for fixing it @Kobzol.

Kobzol commented 8 months ago

Sorry, I forgot to post here :facepalm: