correabuscar
commented
3 months ago To not fail there, the smoke test would have to be modified to accept all args that the test harness can accept[^1], or better yet, have its logic modified to not fail when any args are given to it, like the following (I'd make a PR but it's unclear if it was intended that argv[0] aka exe name be passed to parse() or not, even though in practice it should never be)
diff --git a/tests/smoke.rs b/tests/smoke.rs
index a46f9c0167ab307f..cf1dd1ca487db0e0 100644
--- a/tests/smoke.rs
+++ b/tests/smoke.rs
@@ -4,5 +4,9 @@ use std::env;
#[test]
fn main() {
- getopts::Options::new().parse(env::args()).unwrap();
+ // The test harness can be called with extra args which would panic here,
+ // such as --test-threads=16 -q
+ // thus pretending that it was called with no args, as usual, won't panic,
+ // ergo keeping the program name aka argument at index 0, just as before:
+ getopts::Options::new().parse(env::args().nth(0)).unwrap();
}
While you can modify it to accept `--test-threads` like for example:
```diff
diff --git a/tests/smoke.rs b/tests/smoke.rs
index a46f9c0167ab307f..b0545cb74e28fefd 100644
--- a/tests/smoke.rs
+++ b/tests/smoke.rs
@@ -1,8 +1,10 @@
extern crate getopts;
use std::env;
+use getopts::{Occur, HasArg};
+
#[test]
fn main() {
- getopts::Options::new().parse(env::args()).unwrap();
+ getopts::Options::new().opt("", "test-threads","allows this smoke test to pass while the test harness accepts this arg", "NUM", HasArg::Yes, Occur::Optional).parse(env::args()).unwrap();
}
```
it only works until you decide to use other args like, for example, `-q`:
```
$ cargo test --test smoke -- --test-threads=1 -q
Finished `test` profile [unoptimized + debuginfo] target(s) in 0.05s
Running tests/smoke.rs (target/debug/deps/smoke-a05f567bdd4b3df2)
running 1 test
main --- FAILED
failures:
---- main stdout ----
thread 'main' panicked at /home/user/1tmp/getopts/tests/smoke.rs:9:182:
called `Result::unwrap()` on an `Err` value: UnrecognizedOption("q")
stack backtrace:
0: rust_begin_unwind
at /rustc/129f3b9964af4d4a709d1383930ade12dfe7c081/library/std/src/panicking.rs:652:5
1: core::panicking::panic_fmt
at /rustc/129f3b9964af4d4a709d1383930ade12dfe7c081/library/core/src/panicking.rs:72:14
2: core::result::unwrap_failed
at /rustc/129f3b9964af4d4a709d1383930ade12dfe7c081/library/core/src/result.rs:1654:5
3: core::result::Result::unwrap
at /rustc/129f3b9964af4d4a709d1383930ade12dfe7c081/library/core/src/result.rs:1077:23
4: smoke::main
at ./tests/smoke.rs:9:5
5: smoke::main::{{closure}}
at ./tests/smoke.rs:8:10
6: core::ops::function::FnOnce::call_once
at /rustc/129f3b9964af4d4a709d1383930ade12dfe7c081/library/core/src/ops/function.rs:250:5
7: core::ops::function::FnOnce::call_once
at /rustc/129f3b9964af4d4a709d1383930ade12dfe7c081/library/core/src/ops/function.rs:250:5
note: Some details are omitted, run with `RUST_BACKTRACE=full` for a verbose backtrace.
failures:
main
test result: FAILED. 0 passed; 1 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.05s
error: test failed, to rerun pass `--test smoke`
```
[^1]: which are those you can see via $ cargo test -- --help
When building
rust-getoptswith tests enabled on Guix, I got the following error message:Looks like
--test-threadsisn't supported yet.