search

rust-lang / git2-rs

libgit2 bindings for Rust
https://docs.rs/git2
Apache License 2.0
1.67k stars 384 forks source link

Bind git_submodule_repo_init #914

Closed Hyask closed 1 year ago

Hyask commented 1 year ago

This allows a real initialization of a submodule's repository, where git_submodule_init only leaves you with nothing truly usable.

ehuss commented 1 year ago

Thanks, can you add a test for it?

Hyask commented 1 year ago

Thanks, can you add a test for it?

I thought about it, but after a quick look at the end of submodule.rs, I wasn't really sure where to start. Are there the only submodule tests? I'll try to add something based on existing clone_submodule() test.

ehuss commented 1 year ago

Yea, I think it would go at the bottom of submodule.rs. And yea, I would just start be copying one of the other tests and then adjusting it to utilize the new method.

Hyask commented 1 year ago

I've added a test, do you think it's enough, or is more needed?

Hyask commented 1 year ago

@ehuss thanks for the quick review and the merge. Do you have any idea when this will be released in a tag?