Background:
While working with cargo, I've noticed that it takes ~30s to cargo clean -p with large enough target directory (~200GB). Under a profiler, it turned out that most of the time was spent retrieving paths for removal via glob::glob in rm_rf_glob (and not actually removing the files).
Change description:
In call to .sort_by, we repetitively parse the paths to obtain file names for comparison. This commit caches file names in PathWrapper object, akin to #135 that did so for dir info.
For my use case, a cargo build using that branch takes ~14s to clean files instead of previous 30s (I've measured against main branch of this repository, to account for changes made since glob 0.3.1). Still not ideal, but hey, we're shaving 50% of time off for a bit heavier memory use.
Background: While working with cargo, I've noticed that it takes ~30s to
cargo clean -pwith large enough target directory (~200GB). Under a profiler, it turned out that most of the time was spent retrieving paths for removal viaglob::globin rm_rf_glob (and not actually removing the files).Change description: In call to
.sort_by, we repetitively parse the paths to obtain file names for comparison. This commit caches file names inPathWrapperobject, akin to #135 that did so for dir info.For my use case, a cargo build using that branch takes ~14s to clean files instead of previous 30s (I've measured against main branch of this repository, to account for changes made since
glob 0.3.1). Still not ideal, but hey, we're shaving 50% of time off for a bit heavier memory use.