search

rust-lang / hashbrown

Rust port of Google's SwissTable hash map
https://rust-lang.github.io/hashbrown
Apache License 2.0
2.38k stars 275 forks source link

Make HashSet::insert return OccupiedEntry #495

Closed SUPERCILEX closed 6 months ago

SUPERCILEX commented 7 months ago

See https://github.com/rust-lang/rust/pull/120077#discussion_r1475708665

bors commented 6 months ago

:umbrella: The latest upstream changes (presumably #502) made this pull request unmergeable. Please resolve the merge conflicts.

Amanieu commented 6 months ago

Sorry for the late review, can you rebase to fix conflicts?

SUPERCILEX commented 6 months ago

Sure, done.

Amanieu commented 6 months ago

@bors r+

bors commented 6 months ago

:pushpin: Commit 9beb0d26184d8c2d472afdf2199c42c6f3fadc96 has been approved by Amanieu

It is now in the queue for this repository.

bors commented 6 months ago

:hourglass: Testing commit 9beb0d26184d8c2d472afdf2199c42c6f3fadc96 with merge 274c7bbd79398881e0225c0133e423ce60d7a8f1...

bors commented 6 months ago

:sunny: Test successful - checks-actions Approved by: Amanieu Pushing 274c7bbd79398881e0225c0133e423ce60d7a8f1 to master...

decathorpe commented 5 months ago

Reading this comment: https://github.com/rust-lang/rust/pull/120077#discussion_r1475708665

And the changes (i.e. the signature of the insert function has changed), shouldn't this have been released as v0.15.0 instead of v0.14.4? Or is changing the return type of a function from () to non-() OK?

Amanieu commented 5 months ago

I've yanked the release.

SUPERCILEX commented 5 months ago

Will there be a replacement release for the stdlib?

Amanieu commented 5 months ago

Yes, I'll prepare a new release next week. I've been busy at Rust Nation this week.

SUPERCILEX commented 5 months ago

Oh fun! Sounds good.