search

rust-lang / hashbrown

Rust port of Google's SwissTable hash map
https://rust-lang.github.io/hashbrown
Apache License 2.0
2.38k stars 275 forks source link

Backport #357 for 0.12 #498

Closed Manishearth closed 7 months ago

Manishearth commented 7 months ago

This backports the ahash bump to 0.12 (https://github.com/rust-lang/hashbrown/pull/357). It shouldn't be merged, instead it should be put in a branch/tag and released with a version bump (happy to update this PR to include a version bump if desired)

497 is this PR for 0.11

A bunch of crates out there still use hashbrown at this version (Often via indexmap, still used by the wasmer ecosystem)

It would be nice to get a backport release here. A lot of these dependencies are deep in deptrees and will take time to upgrade.

I also have https://github.com/tkaitchuck/aHash/pull/202 open but it's unclear if that will land

Amanieu commented 7 months ago

Is this still needed now that https://github.com/tkaitchuck/aHash/pull/201 is merged?

Manishearth commented 7 months ago

Not really, could still be worth it since the ecosystem is not yet on newer hashbrown and personally I'd prefer the fix in 0.8, but I don't think it's worth the effort of a backport.