search

rust-lang / hashbrown

Rust port of Google's SwissTable hash map
https://rust-lang.github.io/hashbrown
Apache License 2.0
2.42k stars 283 forks source link

Use a bit less NonNull::new_unchecked #501

Closed saethlin closed 8 months ago

saethlin commented 8 months ago

Using NonNull::cast instead of NonNull::new_unchecked is a bit less unsafe code, and it may provide a small improvement to compile times since https://github.com/rust-lang/rust/pull/120594

saethlin commented 8 months ago

This project's CI is broken due to a dependency on a previous version of itself. Well ain't that something.

Amanieu commented 8 months ago

@bors r+

bors commented 8 months ago

:pushpin: Commit 46f1afcf817d31de64f9e3ac000325a0c5ff4503 has been approved by Amanieu

It is now in the queue for this repository.

bors commented 8 months ago

:hourglass: Testing commit 46f1afcf817d31de64f9e3ac000325a0c5ff4503 with merge cf829443bff78862ee597fb0fdfe8d5fadab96bc...

bors commented 8 months ago

:broken_heart: Test failed - checks-actions

bors commented 8 months ago

:umbrella: The latest upstream changes (presumably #502) made this pull request unmergeable. Please resolve the merge conflicts.

Amanieu commented 8 months ago

I fixed the CI separately in #502, can you rebase?

saethlin commented 8 months ago

Rebased!

Amanieu commented 8 months ago

@bors r+

bors commented 8 months ago

:pushpin: Commit 87d58ecbe9272178d09b329f39ce7fdc1e7afd6f has been approved by Amanieu

It is now in the queue for this repository.

bors commented 8 months ago

:hourglass: Testing commit 87d58ecbe9272178d09b329f39ce7fdc1e7afd6f with merge d563de118001afa9e97f43f6791e255f5c57e766...

bors commented 8 months ago

:sunny: Test successful - checks-actions Approved by: Amanieu Pushing d563de118001afa9e97f43f6791e255f5c57e766 to master...