search

rust-lang / hashbrown

Rust port of Google's SwissTable hash map
https://rust-lang.github.io/hashbrown
Apache License 2.0
2.38k stars 275 forks source link

Consider returning to 1.63.0 MSRV #504

Closed tnull closed 6 months ago

tnull commented 6 months ago

Recently, ahash bumped their MSRV to 1.72.0 in a patch release, which is really unfortunate.

It seems that hashbrown followed a similar pattern in #502 and silently bumped the rustc version in CI to 1.72.0.

Rather than also bumping MSRV (let alone in a patch release), it would be great if hashbrown could revert to a 1.63.0 MSRV, find a workaround, and make recommendations to downstream users that may or may not pin the violating ahash dependency.

It would be great if this path could at least be considered.

Amanieu commented 6 months ago

There's nothing that can be done in hashbrown itself, only in ahash. You could try submitting a PR to restore 1.63 compatibility there by using a build script to detect the rustc version.