search

rust-lang / hashbrown

Rust port of Google's SwissTable hash map
https://rust-lang.github.io/hashbrown
Apache License 2.0
2.46k stars 288 forks source link

Change signature of `get_many_mut` APIs #562

Closed Urgau closed 1 month ago

Urgau commented 2 months ago

This PR changes the signature and contract of the get_many_mut APIs by

  1. panicking on overlapping keys
  2. returning an array of Option rather than an Option of array.

This was asked by T-libs-api in https://github.com/rust-lang/rust/issues/97601#issuecomment-2372109119 regarding the corresponding std HashMap functions.

Amanieu commented 1 month ago

@bors r+

bors commented 1 month ago

:pushpin: Commit d50e3b2475738133630ef5469f3fc488173bf31a has been approved by Amanieu

It is now in the queue for this repository.

bors commented 1 month ago

:hourglass: Testing commit d50e3b2475738133630ef5469f3fc488173bf31a with merge edd22e1d42d681149e06f3652d746bb57297e411...

bors commented 1 month ago

:sunny: Test successful - checks-actions Approved by: Amanieu Pushing edd22e1d42d681149e06f3652d746bb57297e411 to master...