rust-lang / highfive

Github hooks to provide an encouraging atmosphere for new contributors
Apache License 2.0
185 stars 128 forks source link

Don't use startswith when comparing mentions paths. #301

Closed ehuss closed 3 years ago

ehuss commented 3 years ago

This changes it so that paths in "mentions" are compared using full path components instead of a simple string compare. This should fix "src/tools/cargo" from matching "src/tools/cargotest". AFAIK, none of the current mentions are relying on this behavior.

I added a test, though in the process needed to change some things because the existing test infrastructure didn't properly support "mentions".

Fixes #253

pietroalbini commented 3 years ago

Thanks!