rust-lang / highfive

Github hooks to provide an encouraging atmosphere for new contributors
Apache License 2.0
185 stars 128 forks source link

highfive should not assign someone to their own PR #326

Closed joshtriplett closed 2 years ago

joshtriplett commented 3 years ago

In https://github.com/rust-lang/rust/pull/84257 , rust-highfive assigned me to review my own PR.

m-ou-se commented 3 years ago

That's weird. It specifically excludes the author of the PR here:

https://github.com/rust-lang/highfive/blob/a2e3b19385e1cc6a665ca0c0e3226754856c59f9/highfive/newpr.py#L306

Which comes from the last argument here:

https://github.com/rust-lang/highfive/blob/a2e3b19385e1cc6a665ca0c0e3226754856c59f9/highfive/newpr.py#L384-L386

Set here: https://github.com/rust-lang/highfive/blob/a2e3b19385e1cc6a665ca0c0e3226754856c59f9/highfive/newpr.py#L369

m-ou-se commented 3 years ago

Ah, the casing of your username in the high-five config doesn't match the one github uses: JoshTriplett vs joshtriplett

https://github.com/rust-lang/highfive/blob/a2e3b19385e1cc6a665ca0c0e3226754856c59f9/highfive/configs/rust-lang/rust.json#L16

If you click [edit] on https://github.com/rust-lang/rust/pull/84257#issuecomment-821529104, you can see the bot is using JoshTriplett and not joshtriplett (even though github shows the former as the latter).

image image

joshtriplett commented 3 years ago

@m-ou-se Ah, interesting. Ideally the bot should match ignoring case the same way GitHub does, but in the meantime, it sounds like the easiest fix would be to change my username in the configuration to all-lowercase.