search

rust-lang / highfive

Github hooks to provide an encouraging atmosphere for new contributors
Apache License 2.0
185 stars 128 forks source link

Fix the configs pytest #344

Closed flip1995 closed 3 years ago

flip1995 commented 3 years ago

This test was marked as a fixture. This didn't make much sense to me.

Now this test is run as any other test and works, as seen with the rustc-guide json file, where it detected that this file was broken.

r? @Mark-Simulacrum

cc https://github.com/rust-lang/highfive/pull/343#issuecomment-876464166

This was easier than expected, since the test already existed. For some reason it was marked as a fixture, but never used as a fixture in any other test.

In addition this test only checked the _global.json file. Now it checks every json file in the configs dir.

One Two more questions: Should I rename rustc-guide.json to rustc-dev-guide.json while I'm at it or is there a reason why it is still named rustc-guide.json? Also the config file for this repo is still in the rust-lang-nursery dir and I think that is why the rust-highfive bot doesn't do anything on PRs towards this repo. Should I move that file?

flip1995 commented 3 years ago

Just noticed that there are many more config files that still live in rust-lang-nursery, but the repo was moved to rust-lang in the meantime.

Mark-Simulacrum commented 3 years ago

Happy to see followups moving things around, but let's merge this for now.