rust-lang / highfive

Github hooks to provide an encouraging atmosphere for new contributors
Apache License 2.0
185 stars 128 forks source link

Adjust reviewer selection to work on unprefixed group selection #377

Closed Mark-Simulacrum closed 2 years ago

Mark-Simulacrum commented 2 years ago

Previously, r? compiler-team or r? pnkfelix would not be matched by the regexes, which meant that they'd be silently ignored. r? rust-lang/compiler-team already worked, though. Note that if a user and team name overlap, then r? @foo will always map to foo the user, while r? foo will map to the team.

Since we generally don't want the @ prefix on team-wide pings, since it subscribes a bunch of people for no reason, it's nice to avoid necessarily typing the prefix as well. Users in practice do invoke the command in that way.