search

rust-lang / highfive

Github hooks to provide an encouraging atmosphere for new contributors
Apache License 2.0
185 stars 128 forks source link

Re-assigning can assign the current assignee #415

Open davidtwco opened 2 years ago

davidtwco commented 2 years ago

Commenting r? rust-lang/some-team to re-roll can sometimes assign the current assignee - highfive doesn't comment or indicate anything in this scenario, it just looks like highfive didn't notice the comment. Highfive probably shouldn't reassign the current assignee on a re-roll.

Context: https://rust-lang.zulipchat.com/#narrow/stream/242791-t-infra/topic/highfive.20missing.20r.3F/near/289430072

spastorino commented 2 years ago

Same has happened to me and I was surprised. I'd guess that doing r? rust-lang/some-team and then entering the edit/save cycle until it picks someone else is the way to manually solve this issue?.

spastorino commented 2 years ago

Edit/save doesn't work. The only workaround I've found for now is to unassign myself and then re-roll expecting that it picks someone else ...

https://github.com/rust-lang/rust/pull/101492#issuecomment-1241139774

ehuss commented 2 years ago

Just FYI, we are migrating to triagebot, and this issue should be fixed when that happens.

spastorino commented 2 years ago

@ehuss ohh cool, thanks!