search

rust-lang / highfive

Github hooks to provide an encouraging atmosphere for new contributors
Apache License 2.0
185 stars 128 forks source link

Contributor gets welcomed twice if existing commits are to non-default branch #56

Open edunham opened 9 years ago

edunham commented 9 years ago

Is this correct behavior? It seems incorrect, since landing code in any branch of a repo implies knowing how to contribute.

Example:

rust-www was formerly on GitHub pages, so its default branch is currently gh-pages. The graphs show contributions only to gh-pages. I got my first PR merged into master, and highfive welcomed me correctly. However, I was welcomed again on my second PR despite the fact that the first one landed.

nrc commented 9 years ago

It is not correct behaviour. Do you think there's an easy fix? I'm not sure its worth the effort of getting all contributors for all branches and checking them all, or something equally fiddly - after all, being welcomed twice is not such a big deal.

edunham commented 9 years ago

The api docs don't indicate that the call we're using is specific to the default branch, so this may actually be an API bug. They also don't say how to get contributors for a specific branch.

Fix is probably to duplicate/verify the inconsistency between API docs and behavior and report the issue to GithHub.

Making highfive do the right thing in this case looks neither easy nor important for now, but let's leave this issue open as a reminder to report the problem to GitHub eventually.