bors squash does not close PRs

rust-lang / homu

A bot that integrates with GitHub and your favorite continuous integration service

MIT License

183 stars 56 forks source link

bors squash does not close PRs #181

Open RalfJung opened 2 years ago

RalfJung commented 2 years ago

See https://github.com/rust-lang/miri/pull/2541: a PR merged with bors squashing does not get closed.

kellda commented 2 years ago

I think the only way to fix this is to have bors force-push the squased commit to the PR's branch

klensy commented 1 year ago

Partial copypaste from #182: This also left stray commit in bors gh history, and if noone wants to fix that squash for now, it better be disabled (that change should be easy?).

kellda commented 1 year ago

I'm not sure to understand the problem. Do you mean that the "fix verbatim with upstream dependencies" commit should not belong to bors ? If that's what you mean, then it's #136. Is there still another way it behaves unexpectedly ?