rust-lang / homu

A bot that integrates with GitHub and your favorite continuous integration service
MIT License
182 stars 57 forks source link

Don't allow try-builds to be rolled up #189

Open compiler-errors opened 1 year ago

compiler-errors commented 1 year ago

Pending try builds have their checkboxes unchecked, even though the code suggests they should be disabled:

https://github.com/rust-lang/homu/blob/c8f51b8e261541c13747e50097cd8899aae9537b/homu/html/queue.html#L180-L184

image

I can see someone accidentally rolling up a try build because of this :cold_sweat:

compiler-errors commented 1 year ago

state.status == 'pending' and not state.try_ should be False :'(