search

rust-lang / homu

A bot that integrates with GitHub and your favorite continuous integration service
MIT License
183 stars 56 forks source link

Fix delegate comment #193

Closed Urgau closed 1 year ago

Urgau commented 1 year ago

This PR fixes the crash reported when delegating the approval to someone.

The fix use the same approach used by the Approved comment, that is getting the bot name at the creation of the comment.

r? @jyn514

Noratrieb commented 1 year ago

Have you tested this to some degree? Would be great if possible.

Urgau commented 1 year ago

Have you tested this to some degree? Would be great if possible.

No, I haven't unfortunately; but I'm pretty sure it will work since the changes are just copy-pasted from the Approved comment.