search

rust-lang / homu

A bot that integrates with GitHub and your favorite continuous integration service
MIT License
183 stars 56 forks source link

Race condition when PR gets pushed while bors dequeues? #198

Open RalfJung opened 11 months ago

RalfJung commented 11 months ago

Have a look at this:

Commit https://github.com/rust-lang/miri/commit/e9cab75506a68a5bfc102ce734f357d3f1c36dc2 has been approved by RalfJung Testing commit https://github.com/rust-lang/miri/commit/dfd436936396ff080d1b4b09ae1adcf658a44f20 with merge https://github.com/rust-lang/miri/commit/424768dae2adc28b0447d1929916423b68eaad77...

I approved one commit but then it tests a different commit! Surely that should never ever happen, landing unapproved changes?