Closed NobodyXu closed 1 month ago
This also needs a regression test. Apparently nothing ensured that when inheriting a configuration from the parent we pass it through properly to a child.
cc @the8472 Updated, added regression test as suggested.
Also, I'd prefer presenting the regression test first in a commit, followed by the other commits actually fix the behavior and tests. That would make the first commit a minimal reproduction and we know we're fixing the right thing.
That might be a bit hard since I wrote after fixing it
@weihanglo I squashed the commits, can't get the regression test commit to be the first, but it's much smaller now.
@petrochenkov
Would appreciate if you have time publishing this :)
(We should probably revisit https://github.com/rust-lang/jobserver-rs/pull/89 and https://github.com/rust-lang/infra-team/issues/117)
Fixed #99