search

rust-lang / jobserver-rs

Apache License 2.0
68 stars 42 forks source link

Respect to `-n` flag #38

Closed weihanglo closed 2 years ago

weihanglo commented 2 years ago

In the manual of GNU make 13.1.1 POSIX Jobserver Interaction:

Your tool should also examine the first word of the MAKEFLAGS variable and look for the character n. If this character is present then make was invoked with the ‘-n’ option and your tool should stop without performing any operations.

Do we want jobserver to follow the behaviour? It might break someone's misconfigured make invocation, though.

weihanglo commented 2 years ago

Oh no! I looked into pub unsafe fn from_env() -> Option<Client> and think that without changing the return type we cannot inform the caller that "there is a jobserver but they shouldn't proceed". I am going to close it but feel free to reopen it if you think it is worthy.