search

rust-lang / jobserver-rs

Apache License 2.0
69 stars 39 forks source link

use named pipe when creating new jobserver #71

Closed NobodyXu closed 5 months ago

NobodyXu commented 6 months ago

Ref: rust-lang/cargo#13483 rust-lang/cc-rs#962

NobodyXu commented 6 months ago

I propose that we should create named fifo instead of annoymous pipe by default, while retaining compatibility with older make by still passing the fds like this MAKEFLAGS='--jobserver-auth=fifo:/path/to/fifo --jobserver-fds=3,5'.

NobodyXu commented 5 months ago

Unfortunately, --jobserver-auth is introduced in 4.2, but fifo jobserver and --jobserver-style is introduced in make 4.4

This means that if we use fifo we would break backwards compatibility, so closing this for now.