search

rust-lang / jobserver-rs

Apache License 2.0
69 stars 39 forks source link

feature: Impl `Client::{supports_try_acquire, try_acquire}` #73

Closed NobodyXu closed 4 months ago

NobodyXu commented 6 months ago

Resolve #72

NobodyXu commented 6 months ago

@weihanglo The tests failure seems unrelated to the changes in this PR.

The CI is green in my fork and I think it is just a spurious failure.

NobodyXu commented 5 months ago

P.S. I was trying to run cargo +nightly update -Zminimal-versions and got 😂:

thread 'main' panicked at src/cargo/util/context/mod.rs:412:20:
already borrowed: BorrowMutError
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

It seems to pretty persistent when using Cargo.lock from 845870afa49964a97b2fad47053e682fccce9f16

Edit:

Issue is fixed after removing Cargo.lock

weihanglo commented 5 months ago

P.S. I was trying to run cargo +nightly update -Zminimal-versions and got 😂:

thread 'main' panicked at src/cargo/util/context/mod.rs:412:20:
already borrowed: BorrowMutError
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

It seems to pretty persistent when using Cargo.lock from 845870a

Edit:

Issue is fixed after removing Cargo.lock

This was a bug in Cargo https://github.com/rust-lang/cargo/pull/13647. A new nightly with that fix will be out today.