rust-lang / jobserver-rs

Apache License 2.0

69 stars 39 forks source link

fix: preadv2 only available on GNU libc #80

Closed weihanglo closed 4 months ago

weihanglo commented 4 months ago

Technicially it is also available on musl libc 1.2.5, yet the libc@0.2.153 (lastet) doesn't export the symbol, and that version of musl libc is too new (released in 2024-03)

Fixes #79. Tested against Rust docker image alpine3.18

weihanglo commented 4 months ago

@petrochenkov

Could you help do a 0.1.30 release, and after the release yank 0.1.29 then?

petrochenkov commented 4 months ago

@weihanglo @NobodyXu Could you check https://github.com/rust-lang/jobserver-rs/pull/82? It seems fine, but I'm not well trained in noticing issues in CI scripts. I'll make a release once that PR lands.

weihanglo commented 4 months ago

It looks great. It also failed without this PR and now passed, so r+.

weihanglo commented 4 months ago

82 is just merged.

petrochenkov commented 4 months ago

Published 0.1.30 and yanked 0.1.29.